Skip to content

Actually apply before in with_raw_client_for #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Actually apply before in with_raw_client_for #292

merged 1 commit into from
Mar 22, 2025

Conversation

jonhoo
Copy link
Owner

@jonhoo jonhoo commented Mar 22, 2025

I've also marked .map_request as #[must_use] so that failing to use the re-mapped builder gets a warning from the compiler.

Fixes #290.

I've also marked `.map_request` as `#[must_use]` so that failing to use
the re-mapped builder gets a warning from the compiler.

Fixes #290.
Copy link

codecov bot commented Mar 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.44%. Comparing base (5b09ff0) to head (398a2ee).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/client.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/client.rs 63.16% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonhoo
Copy link
Owner Author

jonhoo commented Mar 22, 2025

CI failure is a false positive: obi1kenobi/cargo-semver-checks#1207

@jonhoo jonhoo merged commit c5cec09 into main Mar 22, 2025
19 of 21 checks passed
jonhoo added a commit that referenced this pull request Mar 22, 2025
Actually applies `before` in `with_raw_client_for` (#292)
@jonhoo jonhoo deleted the fix-290 branch March 22, 2025 14:44
@jonhoo
Copy link
Owner Author

jonhoo commented Mar 22, 2025

Released in 0.21.5 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

before closure passed to with_raw_client_for is not set
1 participant