Improve Tests #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 24, 2016 11:33
The extra echo statement was putting out erronious information both to the terminal during tests and to OpenVPN (for example, adding "-p user.local" to the message). Means we don't need to override the log() function as well.
This was set in the last test but not cleared, so subsequent new tests were failing.
Reset the DNS, DOMAIN, and DNSSEC expected options in the loop and then override with what is expected in the test. Will make tests easier to write and expand in the future. Add support for TEST_BUSCTL_DNSSEC for DNSSEC tests.
jonathanio
added
Enhancement
WIP
jonathanio
removed
the
WIP
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve some of the handling around tests as part of the work on
DNSSECsupport.