build: update installation paths #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the changes from this PR are likely to break downstream package builds. |
Summary of changes:
1. Install the scrip to `$(LIBEXECDIR)/openvpn` rather than
installing it into a `/bin` directory,
2. Install the config to `$(DATADIR)/doc/openvpn` rather than
installing it to the same directory as the script, and
3. Install the polkit rules into `$(DATADIR)/polkit-1/rules.d`
rather than installing them to `/etc`.
BREAKING CHANGE: the default `PREFIX` changed (no longer includes
`/bin`).
BREAKING CHANGE: the meaning of `PREFIX` has changed; it is no longer
specific to executable paths.
BREAKING CHANGE: the script now lives in `$(LIBEXECDIR)/openvpn` rather
than in a `/bin` directory.
BREAKING CHANGE: the config file is now installed to
`$(DATADIR)/doc/openvpn/update-systemd-resolved.conf`. By default, this
is `/usr/local/share/doc/openvpn/update-systemd-resolved.conf`.
BREAKING CHANGE: the generated polkit rules go in
`$(DATADIR)/polkit-1/rules.d/10-update-systemd-resolved.rules`. By
default, this is
`/usr/local/share/polkit-1/rules.d/10-update-systemd-resolved.rules`.
Rules must be copied or otherwise propagated into
`/etc/polkit-1/rules.d` in order to take effect.
in place of the nonexisting prereq `$(TEMPLATE_RULES_DEST)`.
BREAKING CHANGE: setups that depend on the default `setenv` definition may break as a result of this change (e.g. if they include the example `update-systemd-resolved.conf`).
tomeon
force-pushed
the
installation-paths-updates
branch
from
248c756 to
34e63a0
Compare
|
Closes #107. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: #107, https://aur.archlinux.org/packages/openvpn-update-systemd-resolved?O=0#comment-775574.