Logging updates #115
Merged
Logging updates #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case `/dev/log` is not a socket or the `logger` command is unavailable. Partially fixes jonathanio#79, or at least permits logging while running in a container without having to specify `/dev/log` as a container volume.
now that the `logger` command is optional.
when probing for what IPv{4,6} expansion implementations are available.
This accounts for the fact that we now optionally support logging
without using the `logger` command.
|
Note: closes #81. |
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
logger, log to stderr (vialogger -s) only if connected to a(p|t)ty.loggerif/dev/logis not a socket or theloggercommand is unavailable.Also document that
util-linuxis now optional, and fix a small issue with unwanted output (overridelog, notlogger, when suppressing "command not found" output while probing for available IP parsing/expansion implementations).