Skip to content

Stage Dialogs (#53) #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 69 commits into from
Apr 11, 2025
Merged

Stage Dialogs (#53) #55

merged 69 commits into from
Apr 11, 2025

Conversation

joedf
Copy link
Owner

@joedf joedf commented Apr 11, 2025 •
edited
Loading

Summary

  • Resolves Improve layout for clarity #53
  • Reorder the stages so that they appear in a more logical layout
  • Added menubar / file-menu with the tradition File, Open, Help, etc
  • Stages are now in jquery-dialogextend dialogs.
    • They can be minimized and collapsed. No maximize or resize for now, to be done with Resizable Stages #54
    • They will snap along a grid.
    • Drawing/rendering is paused for most stages when the corresponding dialog is collapsed or minimized.
  • Made import button bold and bright orange
  • Tweaked stage initial size calculation
  • Minor bugfix in about dialog
  • Lots of code clean up, reduce globals, and styling tweaks

Screenshot

image

joedf and others added 30 commits March 31, 2025 01:12
@joedf
tests with jquery-dialogextend
0065808
@joedf
tweak positioning and styling
4280af3
@joedf
reduce titlebar font size
73c816b
@joedf
tweak inner layout
7d2e129
@joedf
update dialog css, make specific style class
c7f9aea
@joedf
use calc box size, tweak to 4.5/row, fix tiling
5093ff7
@joedf
tweak and bugfix in GetOptimalBoxWidth()
3664b3a 
the max math was wrong, should use min()
@joedf
preview w/ dat.gui and tweak box/row
4f1426e
@joedf
functional dialog version
69b1dca
@joedf
move dialog setup to a js file
48b12a0
@joedf
update title, and switch to min js
329e71d
@joedf
Update testing.dialogs.html
5454193
@joedf
replace index.html
38a0b42
@joedf
work in progress clean up
e4b2c42
@joedf
tweak titlebar offset on 4k screen
cc3a4c5
@joedf
fix image export (as displayed)
2e25bc5
@joedf
tweak titlebar h offset on 1080p
d4d8939
@joedf
tweak box sizing again, some clean up
61db488
@joedf
more eslint clean up
70e6468
@joedf
fix clean up issues
249c852
@joedf
add missing doc line
063a62e
@joedf
dialogsetup.js: start clean up
73175b3
@joedf
Continuing clean up
592642a
@joedf
more cleanup, reduce globals
9afc7b6
@joedf
reduce more globals
6e60aec
@joedf
update comment
1506a25
@joedf
rename to layout.js
f3ae0a7
@joedf
reduce G_STAGES global
cde0f75
@joedf
more cleanup
9506e52
@joedf
fix clampValue()
314b31b
joedf added 21 commits April 4, 2025 12:51
@joedf joedf added enhancement New feature or request VnV Verification and Validation labels Apr 11, 2025
@joedf joedf linked an issue Apr 11, 2025 that may be closed by this pull request
Improve layout for clarity #53
Closed
@joedf joedf marked this pull request as ready for review April 11, 2025 18:18
joedf
joedf commented Apr 11, 2025
View reviewed changes
Copy link
Owner Author

@joedf joedf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, need to jsdoc comment for LayoutManager.Initialize()

@joedf joedf merged commit fc638b5 into main Apr 11, 2025
@joedf joedf deleted the feature/53_layout_testing branch April 11, 2025 18:38
joedf added a commit that referenced this pull request Apr 11, 2025
@joedf
update jsdocs for #55
a2fc7d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request VnV Verification and Validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve layout for clarity
1 participant
@joedf