Add site logo and favicon to Application Settings #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,8 @@ return new class extends Migration | |||
| $table->id(); | |||
| $table->string('site_name')->nullable(); | |||
| $table->text('site_description')->nullable(); | |||
| $table->string('site_logo')->nullable(); | |||
There was a problem hiding this comment.
You should create a new migration because you can't force the user to recreate.
And need to put in the documentation something to force run the command to create new fields with new migration.
And is better to avoid bug to people that have now, create a feature/flag to show these 2 fields only if enable it
There was a problem hiding this comment.
My bad, I hope my new commit fixes that. Thanks for your feedback.
There was a problem hiding this comment.
Thanks man, I will see this soon @KaramNassar
| @@ -18,6 +20,26 @@ public static function get(): array | |||
| Textarea::make('site_description') | |||
| ->label(__('filament-general-settings::default.site_description')) | |||
| ->columnSpanFull(), | |||
| Grid::make()->schema([ | |||
There was a problem hiding this comment.
Here can show this two fields depends if enable in the AdminPanel to avoid bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.