fix: use dpkg-query to check for installs
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, `oxidizr` checked if packages were installed by checking for the word `installed` in the output of `apt list <pkg>`, which works fine all the time `apt` is in English, but not so well if the system uses a different locale. This commit instead relies upon `dpkg-query -s`, which fails if the package is not installed.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit,
oxidizrchecked if packages were installed by checking for the wordinstalledin the output ofapt list <pkg>, which works fine all the timeaptis in English, but not so well if the system uses a different locale.This commit instead relies upon
dpkg-query -s, which fails if the package is not installed.Fixes #9