Skip to content

Should InvocationDispatcher be updated when ThreadingPolicy is changed? #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikeh opened this issue Jan 11, 2019 · 3 comments
Closed

Should InvocationDispatcher be updated when ThreadingPolicy is changed? #121

spikeh opened this issue Jan 11, 2019 · 3 comments
Assignees
@olibye
Labels
compatibility threads

Comments

@spikeh
Copy link

spikeh commented Jan 11, 2019

At the moment, InvocationDispatcher in Mockery is marked final. So after changing ThreadingPolicy, the old dispatcher (from a SingleThreadedPolicy) continues to be used. The original dispatcher receives both added expectations and invoked invocations.

All 6 tests in org.jmock.test.unit.lib.concurrent.internal.SynchroniserTests fail.

For some reason, no tests are run in org.jmock.junit5.unit.lib.concurrent.internal.SynchroniserTests.

I'm working on an extension to jMock that is currently a fork, which is difficult to maintain and keep up to date. I'm looking at moving the extension out with jMock as a dependency instead.
@olibye
Copy link
Member

olibye commented Jan 16, 2019

I'll look into this

@olibye olibye closed this as completed Jan 16, 2019
@olibye olibye reopened this Jan 16, 2019
@olibye
Copy link
Member

olibye commented May 18, 2019

I'm sorry I've not had time to look at this.
I now see why junit5 tests are failing.
I'm working on a fix

@olibye olibye self-assigned this May 18, 2019
@olibye olibye added this to the 2.12.0 milestone May 18, 2019
@olibye olibye pinned this issue May 18, 2019
@olibye olibye removed this from the 2.12.0 milestone May 18, 2019
@olibye olibye mentioned this issue May 18, 2019
Merged
olibye added a commit that referenced this issue May 18, 2019
@olibye
Merge pull request #128 from olibye/master
29efca3 
Fix Synchroniser issue #121 and ByteBudderImposteriser ClassLoader issue #127
@olibye
Copy link
Member

olibye commented May 18, 2019

Solve in master, released in 2.12.0-SNAPSHOT

@olibye olibye closed this as completed May 18, 2019
@olibye olibye unpinned this issue May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olibye olibye

Labels
compatibility threads
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olibye @spikeh