Workaround on finding Boost #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jll63
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
I still think that auto downloading dependencies, while may have made sense a while ago, should be an explicit opt-in now. I really want to eliminate the need for a patch in vcpkg context. Can we work towards this goal? I am going to fix the docs.in inclusion issue.
I found a couple of bugs in 1.5.0. I am going to make a 1.5.1 version soon. You bump vcpkg or I do?
|
1.5.1 is out. |
|
I made the PR for v1.5.1 microsoft/vcpkg#38450 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be a workaround to #43. I wanted to do a clean-up and a full replacement of in-build install via https://github.com/boostorg/cmake, but I faced some incompatibility: it is not offering a valid
Boost::headerstarget (each lib has to be linkedBoost::mp11, CMake complains the dependent targetboost_headersis not exported, FetchContent_Declare on Windows is slow.In absence of valid full replacement, I propose this minor change to check for system/user provided Boost first before trying to deal with it as before.