-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: support param in sm batch #6229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6229 +/- ##
===========================================
+ Coverage 19.02% 60.77% +41.75%
===========================================
Files 150 152 +2
Lines 14226 14301 +75
===========================================
+ Hits 2706 8691 +5985
+ Misses 11520 5610 -5910
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please define what is being done with more detail.
9c251a4
to
eac3089
Compare
Goals:
Currently, the FastAPI provided by
jina
can’t handle SageMaker Batch Transform requests when both the doc list and parameters (e.g., late_trunking set to True/False) need to be considered. In the CSV, there’s no way to specify parameters.This PR introduces a way for users to set both the document list and parameters. While it’s not the cleanest solution, it works.
Essentially, the first row will be used for parameters, and it must include
params_row
as a signature to identify it as the parameters row. The remaining rows will still be used as doc rows.Example: