Lowercase for Docker build Name in documentation #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
thanks @Pierre48 and congratulations for your first contribution here ! 🎉 |
|
Done :) |
|
@Pierre48 Sorry I didn't check the target branch. You have target master but the new github convention is main can you reopen your PR on the main ? We have kept the master for the moment but it will be deleted soon |
4 tasks
nicolas63
added a commit
that referenced
this pull request
Feb 7, 2021
Co-authored-by: Pierre48 <[email protected]>
A-5ingh
pushed a commit
to A-5ingh/jhipster-dotnetcore
that referenced
this pull request
Feb 19, 2025
Co-authored-by: Pierre48 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name components may contain lowercase letters, digits and separators.https://docs.docker.com/engine/reference/commandline/tag/
Please make sure the below checklist is followed for Pull Requests.
All continuous integration tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed