Skip to content

Correct the syntax in hero is-bold colour variants #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025

Conversation

bagedevimo
Copy link
Contributor

@bagedevimo bagedevimo commented Dec 18, 2024

While the prior syntax does produce valid css, it's not quite valid scss and so produces warnings in various pre and post-processing pipelines which various upstream consumers of Bulma may use.

This is a bugfix.

Proposed solution

By using the correct scss syntax, we just prevent downstream warnings and errors, and make this file consistent with the rest of the bulma codebase., for example:

#30 114.5 WARNING in css/partner_portal-d7c813d1.css
#30 114.5 css/partner_portal-d7c813d1.css from Css Minimizer plugin
#30 114.5 postcss-calc:: Lexical error on line 1: Unrecognized text.
#30 114.5 
#30 114.5   Erroneous area:
#30 114.5 1: var(--bulma-hero-h) - $hero-gradient-h-offset
#30 114.5 ^........................^ webpack://./node_modules/bulma/sass/layout/hero.scss:146:12

Testing Done

Generated css output has no difference before and after this change.

Changelog updated?

No.

While the prior syntax does produce valid css, it's not quite valid scss
and so produces warnings in various pre and post-processing pipelines
which various upstream consumers of Bulma may use.
@jgthms jgthms merged commit 3c5e2ae into jgthms:main Apr 19, 2025
@bagedevimo bagedevimo deleted the hero-bold branch April 20, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants