Skip to content

Add fail_pr in simple json conversion - Sca, Licences, IaC, Sast, Secrets #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Jun 16, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

This PR adds the new FailPullRequest (or fail_pull_request) value taken from the scans results Sarifs to the Simple-Json conversion for the following scans: Sca, Licences, IaC, Sast and Secrets
This change supports the new fail_pr rule that recently introduced that enables to fail_pr when a violation with fail_pr rule is found in one of the scanners.
This ability is supported in Frogbot scan-pr only.

Depends on: jfrog/jfrog-client-go#1135

@eranturgeman eranturgeman added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Jun 16, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 16, 2025
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jun 17, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 17, 2025
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jun 17, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 17, 2025
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jun 19, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants