Skip to content

Enable Custom Secrets Scanners #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Jun 11, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Depends on:

  • AnalyzerManager v1.21.0

parsing the new property origin and displaying it at the outputs

image
image

@attiasas attiasas added the improvement Automatically generated release notes label Jun 11, 2025
@attiasas attiasas requested review from orz25 and hadarshjfrog June 11, 2025 09:18
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 11, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 11, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 11, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 11, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 15, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 15, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 16, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 16, 2025
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 16, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 16, 2025
Copy link
Contributor

@hadarshjfrog hadarshjfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the origin fields to the test files.
Also - can we create one in the platform? so we could have integration tests for it as well? (The test should skip the test if it doesn't have a custom secret of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants