Skip to content

Fix jf eot response to a valid json #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 128 commits into from
May 5, 2025
Merged

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Apr 23, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

🧹 Fix JSON formatting in OIDC credentials logging

Summary

This PR fixes a formatting issue in the JSON output used for logging OIDC credentials. Previously, the log message included an invalid JSON structure, which could break parsers or confuse readers. Now, the credentials are properly serialized using json.MarshalIndent.

omerzi and others added 30 commits April 5, 2023 10:15
* Improve UI for scan command (jfrog#706)

* Upgrade go version in go.mod to 1.20 (jfrog#732)

* Fix lint issues found (jfrog#733)

* Config transfer - ensure target not older than source (jfrog#721)

* Update tests environment - nuget and dotnet to version 6  (jfrog#734)

* Flatten audit graph (jfrog#736)

* Use gradle-dep-tree with Audit (jfrog#719)

---------

Co-authored-by: Sara Omari <[email protected]>
Co-authored-by: Eyal Ben Moshe <[email protected]>
Co-authored-by: Michael Sverdlov <[email protected]>
Co-authored-by: Yahav Itzhak <[email protected]>
# Conflicts:
#	.github/workflows/analysis.yml
#	go.mod
#	go.sum
#	xray/audit/java/gradle.go
#	xray/commands/audit/generic/auditmanager.go
@EyalDelarea EyalDelarea added the breaking change Automatically generated release notes label Apr 23, 2025
@EyalDelarea EyalDelarea added bug Something isn't working and removed breaking change Automatically generated release notes labels Apr 23, 2025
@EyalDelarea EyalDelarea marked this pull request as ready for review April 23, 2025 10:28
@EyalDelarea EyalDelarea merged commit 0ba559a into jfrog:dev May 5, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.