Update engines field #198
Merged
Update engines field #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lydell
reviewed
Jul 8, 2024
package.json
Outdated
| @@ -114,7 +114,7 @@ | |||
| }, | |||
| "packageManager": "[email protected]", | |||
| "engines": { | |||
| "node": ">=14.18" | |||
| "node": ">=16 || 14 >= 14.18" | |||
There was a problem hiding this comment.
Is 14 >= 14.18 a valid constraint? If so, what does it mean?
There was a problem hiding this comment.
Yes. It means that you need at least node 16, or a version of 14 greater than or equal to 18.
It excludes node 15.
There was a problem hiding this comment.
That space is wrong though. I'll go fix that.
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
This is our actual bare minium node right now.
lishaduck
force-pushed
the
correct-engines
branch
from
5f5ec80 to
5bc34e9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Right, we don't want to support Node.js 15 if possible. |
We don't? I thought I'd just dropped it accidentally without dropping it in engines :man_shrugging_nonchalantly: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is our actual bare minimum Node.js version right now.
I'd forgotten to exclude versions without Node.js 16 backports (i.e., Node.js 15).
Extracted from #190.