Change progress_mark with increment

[noctivityinc]

Current Problem

This is a sweet gem. The only issue is that the progress_mark is always the same, which isn't always helpful.

For example I will get this

======= 7 ===== ETA: XX:XX:XX

But there are often times that I want to see if there was an issue, and for that I'd like to see a different mark, such as:

==x==== 7 ======

Potential Solution or New Behavior

Simple. I'd like to be able to do

bar.increment('x')

which would output that mark if specified on the progress bar.

Mockups

==x==== 7 ======

[jfelchner]

This is more complicated than it first appears.

Let me give you an example:

|=========>          |

In this example, the bar takes up 10 spaces. The empty space takes up 10 spaces. If the bar represented 20 items, then it would be reasonable to say that when the bar is incremented, we add the mark sent to increment and show it instead of the default mark. But let's say the total amount that the bar is representing is 2,000 items. Now each "tick" of the bar represents 100 items. If we were to increment('x'), should the entire tick mark representing the other 199 items also be considered x?

Then this will invariably lead to someone saying "Can I have the bar show me the mark representing the most items for that tick mark?". It will open up a large can of worms.

Now, I'm not saying I'm opposed to this, I'm just saying it's not as simple as what you're suggesting.

If you want to give it a shot and open a proof of concept PR, I'd be willing to discuss it.

[jfelchner]

Gonna close this for now but if I get a spike PR I'm happy to discuss it further :)