Revert changes for source map suppport (#5945) #6106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SimenB is it normal that a snapshot that passes on Node 8 and 9, fails on 6? |
|
Sounds like the same thing as #5932 (comment) |
|
FWIW, I'd rather fork and publish sourcemap-support with my hack and use that, or at least give them a few days, before reverting. |
|
@SimenB Let's revert for the moment and we'll get it back once there's the forked version and/or the patch in + the release of the module. |
SimenB
added a commit
to SimenB/jest
that referenced
this pull request
May 13, 2018
…)" This reverts commit 45cd277.
SimenB
added a commit
to SimenB/jest
that referenced
this pull request
May 15, 2018
…)" This reverts commit 45cd277.
SimenB
added a commit
to SimenB/jest
that referenced
this pull request
May 18, 2018
…)" This reverts commit 45cd277.
SimenB
added a commit
to SimenB/jest
that referenced
this pull request
May 22, 2018
…)" This reverts commit 45cd277.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5945 we accidentally introduced a memory leak that makes all tests leak. This was detected with the help of @SimenB, by running the
--detectLeaksflag against the own suite.It turns out that the fix needs to be done in
source-map-support, for which a PR has been put up. In the meantime, we will revert the commit.