tests(colors): Force-disable colors on tests for consistent snapshots #5646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** We are having test failures due to mismatched snapshots on TravisCI and on some other systems since colors are not consistently used during tests. This patch forces colors to be off during tests via `runJest` so they are always consistent. **Test plan** Existing tests should pass. TravisCI builds should also be fixed.
Codecov Report
@@ Coverage Diff @@
## master #5646 +/- ##
=======================================
Coverage 62.35% 62.35%
=======================================
Files 216 216
Lines 7908 7908
Branches 3 3
=======================================
Hits 4931 4931
Misses 2976 2976
Partials 1 1Continue to review full report at Codecov.
|
mjesun
approved these changes
Feb 23, 2018
BYK
added a commit
that referenced
this pull request
Feb 24, 2018
Summary Follow up to #5646. Forces `chalk` to be turned on in matcher tests for consistent snapshot output. Should fix tests on TravisCI. Test plan Existing tests should pass. TravisCI should pass.
BYK
added a commit
that referenced
this pull request
Feb 24, 2018
## Summary Follow up to #5646. Forces `chalk` to be turned on in matcher tests for consistent snapshot output. Should fix tests on TravisCI. ## Test plan Existing tests should pass. TravisCI should pass.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are having test failures due to mismatched snapshots on TravisCI
and on some other systems since colors are not consistently used
during tests. This patch forces colors to be off during tests via
runJestso they are always consistent.Test plan
Existing tests should pass. TravisCI builds should also be fixed.