console.assert from Puppeteer showing up in terminal after upgrading to v22.3.0

[cdeutsch]

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

console.assert from puppeteer is showing up in terminal when running tests.

What is the expected behavior?

The console.assert calls didn't show up in v22.1.4

[cdeutsch]

Would the recent changes to Console.js or buffered_console.js cause this?
v22.1.4...v22.3.0

[SimenB]

Yeah, this is #5514. The one from Page.js:648 looks legit, but we should not print the stackframe if there's nothing to log in an assert.

@ranyitz mind taking a look?

[ranyitz]

@SimenB I agree, I will fix it later on today.

[emilianionascu]

Thank you for the fix. Is there a new release coming for it or perhaps a way to disable the assertions until the official fix?

[SimenB]

you should be able to do console.assert = jest.fn() in a setupfile

[emilianionascu]

@SimenB could you be more specific? I'm rather new to Jest, trying to use it with Puppeteer in a regression testing suite. I've created a jest.config.js file and tried to set it there assuming that console.assert were global. That didn't work.

[clement-bramy]

@emilianionascu

yourproject/tests/something.test.js

console.assert = jest.fn();
describe('your Jest test suite start here', () => {
  test('your unit test (or whatever you are doing)', () => {
    // do something
  });
});

works for me.

[SimenB]

22.4.0 is released, btw, so this shouldn't be needed anymore

[SimenB]

Oh, this wasn't closed.

#5576

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.