Add try_get_or_insert() method #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromefroe
reviewed
Jun 24, 2023
There was a problem hiding this comment.
Thanks for the contribution @redforks, this looks great! Before merging, mind adding a test for the new function?
|
There is a doc-test, I though that is enough. I'll add a unit-test later, thanks for review my commit |
|
Added unit test for try_get_or_insert() method |
|
@redforks sorry for the delay getting back to this, everything looks good to me, CI is just failing because of formatting. I'm going to merge this pull request as-is and fix the formatting issue in a follow up PR. |
Merged
|
Thanks, I'll pay attension to the code format next time |
No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If key not cached, and the FnOnce need return Result<>,
get_or_insert()method will hard to use, I dive into a fewLruCacheDependents crates, they query the cache first, if not exist in cache, generate the value (possible Err), thensave the result into cache. Requires two hash op, and make the code logic a bit complex.