very minor, init accepts binary strings #39
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes please fix the spec. Also, please reword your commit message to something that describes what you're doing more explicitly and without the editorial information. Thanks! |
|
I added the spec change and ran Dialyzer, and change the wording without commentary. |
|
Last thing: can you merge your commits? Compiling the first one will fail with warnings. All commits should generally be independently buildable and testable. |
Fixed start_link spec to include binary option on URL
|
There you go, squashed. |
jeremyong
added a commit
that referenced
this pull request
Mar 10, 2015
very minor, init accepts binary strings
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think its a common use case to have the URL as a binary string, so I added a start_link clause.