Implement Mul for Transform #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like it is implemented in SFML like such, so I copied the behavior from SFML to here.
dogunbound
force-pushed
the
mulForTransform
branch
from
b36957b to
fb59e47
Compare
| /// assert_eq!(test_transform * test_transform, result); | ||
| /// ``` | ||
| fn mul(self, rhs: Self) -> Self::Output { | ||
| let mut clone_self = self; |
There was a problem hiding this comment.
You could just make self mut in the parameter list. But this is fine too I guess.
There was a problem hiding this comment.
Wait, so the base SFML implementation has it where it clones itself like so. would that do the same here? I actually don't know. If it just clones self if i put mut there, then yeah I should have done it like that. Oh well. I don't know everything about rust :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like it is implemented in SFML like such, so I copied the behavior from SFML to here.
Issue: #203