Skip to content

Updates #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Updates #92

merged 2 commits into from
Dec 18, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Dec 18, 2019

Continuation of #91 by @slonopotamus, picking up jenkinsci/subversion-plugin#240 while adapting to jenkinsci/subversion-plugin#183 + jenkinsci/subversion-plugin#223, all originally (?) to adapt to jenkinsci/jenkins-test-harness#166. Follow-ups would be

@jglick jglick requested a review from dwnusbaum December 18, 2019 15:49
@slonopotamus
Copy link
Contributor

To be more exact, workflow-multibranch-plugin only needs newer mapdb-api in order to adapt for jenkinsci/jenkins-test-harness#166. Either by doing it itself (as was done in #90) or by bumping subversion to >= 2.13.0. Latter makes more sense because bogus mapdb-api is a dependency of subversion, workflow-multibranch-plugin doesn't want to know anything about mapdb.

@slonopotamus slonopotamus mentioned this pull request Dec 18, 2019
Comment on lines +133 to +135
static {
System.setProperty(SubversionSCMFileSystem.DISABLE_PROPERTY, "true");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to tear this down in between tests, or do we always want it to be true, so it doesn't really matter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not really matter I think.

@jglick
Copy link
Member Author

jglick commented Dec 18, 2019

BTW locally I am getting a failure from ReplayActionTest.scriptFromSCM though it seems to work on CI:

A branch named 'master' already exists.

Not going to worry about it right now, and unrelated to subversion (this is a git-based test).

@dwnusbaum dwnusbaum merged commit 45b2726 into jenkinsci:master Dec 18, 2019
@jglick jglick deleted the bumps branch December 18, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants