Skip to content

[JEP-210] Log handling rewrite #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 71 commits into from
Oct 4, 2018
Merged

[JEP-210] Log handling rewrite #27

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
c229421
[JENKINS-38381] Prototype of log handling rewrite.
jglick Sep 23, 2016
754ab9e
Pick up https://github.com/jenkinsci/maven-hpi-plugin/pull/25.
jglick Sep 26, 2016
e3ccb7b
Updated dependency versions.
jglick Sep 26, 2016
721bc75
Obsolete Javadoc comment.
jglick Sep 26, 2016
30d64c7
Reproduced AssociatedNodeNote error in a test.
jglick Sep 26, 2016
78c5fbf
Another snapshot version forgotten.
jglick Sep 26, 2016
875b3ed
Lighter-weight way of marking which node printed a line.
jglick Sep 26, 2016
f2f1296
FindBugs
jglick Sep 27, 2016
141d748
Updated TODOs.
jglick Sep 27, 2016
19530bd
Extracting createBuildListener.
jglick Sep 30, 2016
4579f77
2.16 parent
jglick Oct 3, 2016
6f1ab49
Prototype SPI for replacing the log file of a build.
jglick Oct 5, 2016
e57d7c6
Deleting comment implemented as https://github.com/jenkinsci/jenkins-…
jglick Oct 6, 2016
7db5d9d
Faulty _getLogInputStream caused StackOverflowError’s in the normal c…
jglick Oct 6, 2016
e4968ef
Pending https://github.com/jenkinsci/jenkins-test-harness/pull/38 avo…
jglick Oct 7, 2016
e6a58e8
Reimplemented HTML display of Pipeline console to include some featur…
jglick Oct 10, 2016
f46b98c
FindBugs
jglick Oct 11, 2016
62ccf49
Hide the show/hide link except during hover.
jglick Oct 12, 2016
51fdc25
Do not hide a “show” link.
jglick Oct 12, 2016
d34d03e
[JENKINS-27394] Better implementation of collapsible sections, finall…
jglick Oct 12, 2016
aa12940
Discovered a problem with NewNodeConsoleNote and LabelAction.
jglick Oct 12, 2016
08268a3
Found a fix for the LabelAction timing problem.
jglick Oct 12, 2016
d2a39dd
Fixed a bug in enclosing logic.
jglick Oct 12, 2016
89559d5
Noting LessAbstractTaskListener.
jglick Oct 14, 2016
211bd14
Merge branch 'master' into logs-JENKINS-38381
jglick Dec 7, 2016
72d29d0
hpi-plugin.version=1.121
jglick Dec 16, 2016
2de9add
getLog should take a long start argument.
jglick Dec 21, 2016
b0c6369
Need https://github.com/jenkinsci/maven-hpi-plugin/pull/48 to get hpi…
jglick Dec 21, 2016
0f511fa
Giving up on jitpack for now.
jglick Jan 3, 2017
c88e980
Added a crude scalability test.
jglick Jan 3, 2017
a0e766b
Stronger assertions.
jglick Jan 4, 2017
c7b8610
Adapted test to annotateHtml coalescing change.
jglick Jan 6, 2017
33e9151
Switched to enclosingId to simplify JavaScript.
jglick Jan 7, 2017
a8ea094
Adapted test to new behavior of NewNodeConsoleNote.
jglick Jan 7, 2017
24266f8
Merge branch 'master' into logs-JENKINS-38381
jglick Feb 5, 2018
59ba822
Minor build errors.
jglick Feb 5, 2018
2ecc99f
Merge branch 'UTF-8-JENKINS-31096' into logs-JENKINS-38381
jglick Feb 13, 2018
1c75a1c
Merge branch 'UTF-8-JENKINS-31096' into logs-JENKINS-38381
jglick Jun 11, 2018
4c8c8ab
Skipping an expensive test on Windows which currently fails anyway.
jglick Jun 11, 2018
a01addc
Use the latest LTS as a baseline.
jglick Jun 11, 2018
a86881f
TestUnit2 unnecessarily restricted.
jglick Jun 11, 2018
18d78f3
Race condition finishing build caught by WorkflowRunRestartTest.lazyL…
jglick Jun 11, 2018
ab259f8
Merge branch 'UTF-8-JENKINS-31096' into logs-JENKINS-38381
jglick Jun 15, 2018
976c775
Apparent race condition in NewNodeConsoleNote sometimes resulting in …
jglick Jun 15, 2018
216223d
Removed reference to obsolete LessAbstractTaskListener.
jglick Jun 18, 2018
c2f2a8f
Passing complete flag to getLog.
jglick Jun 18, 2018
46bf528
Refactored to LogStorage.
jglick Jun 20, 2018
39779fc
Bumps.
jglick Jun 20, 2018
ae2b07e
Javadoc fix.
jglick Jun 21, 2018
5616213
FindBugs
jglick Jun 21, 2018
d41f02f
Fixing deprecation warnings in test.
jglick Jun 25, 2018
9c48541
Merge branch 'master' into logs-JENKINS-38381
jglick Jul 24, 2018
4c76b65
Merge branch 'UTF-8-JENKINS-31096' into logs-JENKINS-38381
jglick Aug 6, 2018
49c91cd
Merge branch 'master' into logs-JENKINS-38381
jglick Aug 7, 2018
096aeab
Adapted to FileLogStorage.
jglick Aug 13, 2018
d450172
Replacing deprecated FlowScanningUtils.fetchEnclosingBlocks with Flow…
jglick Aug 15, 2018
8873326
Found a couple of places where WorkflowRun.listener was being imprope…
jglick Aug 15, 2018
acd07c0
Updated comments.
jglick Aug 15, 2018
3474475
Nulling out listener after close, and expanding upon an earlier comme…
jglick Aug 15, 2018
17a0d2a
Logging a condition which is probably impossible.
jglick Aug 17, 2018
0a39b1c
Showing that it is quick (0ms for me) to display short node log text …
jglick Aug 23, 2018
6eac61d
Merge branch 'master' into logs-JENKINS-38381
jglick Sep 4, 2018
6f5d227
Apparently flaky tests.
jglick Sep 4, 2018
2aa0348
Obsolete comment.
jglick Sep 5, 2018
ae21cee
Demonstrating that a JEP-210 upgrade preserves both whole-build and s…
jglick Sep 6, 2018
5854f54
Avoid duplicated labels on blocks.
jglick Sep 7, 2018
e830112
Merge branch 'master' into logs-JENKINS-38381
jglick Sep 10, 2018
f9325b5
Bumps.
jglick Sep 24, 2018
46f8333
Under certain conditions behaviors can be repeatedly applied, so they…
jglick Sep 24, 2018
9e07b63
Call AsynchronousExecution.completed even if saving build.xml fails. …
jglick Oct 1, 2018
5623f82
compatibleSinceVersion=2.26
jglick Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>2.5</version>
<relativePath />
<version>2.15</version>
<relativePath/>
</parent>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-job</artifactId>
Expand All @@ -52,40 +52,51 @@
<repositories>
<repository>
<id>repo.jenkins-ci.org</id>
<url>http://repo.jenkins-ci.org/public/</url>
<url>https://repo.jenkins-ci.org/public/</url>
</repository>
</repositories>
<pluginRepositories>
<pluginRepository>
<id>repo.jenkins-ci.org</id>
<url>http://repo.jenkins-ci.org/public/</url>
<url>https://repo.jenkins-ci.org/public/</url>
</pluginRepository>
</pluginRepositories>
<properties>
<jenkins.version>1.642.3</jenkins.version>
<hpi-plugin.version>1.120</hpi-plugin.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally should be updated in the Parent POM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review jenkinsci/plugin-pom#35. :-)

</properties>
<dependencies>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-api</artifactId>
<version>2.5-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-support</artifactId>
<version>2.2</version>
<version>2.9-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>structs</artifactId>
<version>1.5</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-cps</artifactId>
<version>1.15</version>
<version>2.18</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-basic-steps</artifactId>
<version>1.15</version>
<version>2.2</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-support</artifactId>
<version>1.15</version>
<version>2.9-SNAPSHOT</version>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
Expand Down
Loading