Remove unnecessary workarounds #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Jul 27, 2023
|
I think jenkinsci/script-security-plugin#420 can also be cleaned up now; will file it if you were not already planning to do so. |
|
Yup, that was next on my list: jenkinsci/script-security-plugin#517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops support for OpenJDK versions older than 11.0.17 on the 11 LTS line and 17.0.4 on the 17 LTS line, both now about a year old. The impact when running without these workarounds on older OpenJDK versions is that you may be subject to memory leaks. It seems worth it to simplify this hard-to-maintain reflection-based code and drop support for these older runtime environments. See also jenkinsci/jenkins#8193.