update workflow-api version 2.40

[joseblas]

This update is needed for PCT issues

[dwnusbaum]

This looks fine, but do you have any context? Is this because of a plugin split or something in core? Are you trying to fix PCT issues, etc? It is very helpful to link to any relevant upstream PRs so that anyone looking through in the future can figure out why this was needed, and so anyone looking at the upstream PR can see what plugins were forced to adapt because of the change, etc.

[jglick]

There is no context given. Maybe the PR title could say something about adapting to new ssh-slaves releases or something?

[jglick]

Can you use the BOM instead?

[joseblas]

do you mean to add a bom to the ssh-slaves plugin?

[jglick]

No, to use jenkinsci/bom here rather than hard-coding individual plugin versions. Not necessary and could be done as a follow-up of course.

[joseblas]

lgtm, I will do it in another branch. Thanks

[dwnusbaum]

Ok, I tried to track down the reason for the change. My best guess is that it is because jenkinsci/ssh-agents-plugin#114, released in ssh-slaves 1.30.0, broke binary compatibility by removing deprecated methods on SSHLauncher which we were using in tests, and because that PR updated the Jenkins core dependency to a newer version than this plugin.