Add a property to specify the icon of the result #1919
Conversation
|
Can I deploy a custom icon to the userContent directory and reference that? |
Yes, that works as well. I'll add that to the documentation of the property. |
|
How about an URL pointing to an external site? Like https://aka.ms/msbuildicon. |
It seems that Jenkins also does support that... I never tried that before but it works out of the box. |
In #1919 a new icon property has been added to the recorder. This accidentally broke the URL mapping of the warning results. When a custom ID is given, then this ID will be used as URL. Only for empty URLs, the default ID of the label provider will be used. Additionally, the log messages have been fixed when the ID is used in tool and recorder (see JENKINS-75391).
| final ResultHandler resultHandler) throws IOException, InterruptedException { | ||
| final ResultHandler resultHandler, final LogHandler logHandler) throws IOException, InterruptedException { | ||
| if (analysisTools.isEmpty()) { | ||
| throw new IllegalStateException("No tools configured to record issues"); |
There was a problem hiding this comment.
👋 Hello! This seems to be a breaking behavioral change; can it be rolled back and reintroduced in a dedicated major release? Alternatively, can the docs be updated to say that tools isn't actually optional, i.e. clarify that you need one of tool or tools? Thanks!
There was a problem hiding this comment.
I wonder why someone should call the recorder without tools. But if that should be better documented, please file a PR for the documentation (or for the help files).
There was a problem hiding this comment.
I wonder why someone should call the recorder without tools.
The issue is that the docs for the step show both of these as "(Optional)".
I think the "(Optional)" is generated from the code, so I assume it can't really be changed (since technically you only need one or the other). If that's the case—and please correct me if I'm wrong—I will just see about adding a sentence to the doc clarifying this relationship and the fact that exactly one of them is required. Thanks!
Add a new property
iconto override the default icon for the results.The icon can be given for the tool or for the overall results: