Merge pull request #1963 from Jay-oao/JENKINS-57636

Display Project Actions from previous builds when missing in latest build

Author: uhafner

plugin/src/main/java/io/jenkins/plugins/analysis/core/model/MissingResultFallbackHandler.java

@@ -0,0 +1,82 @@
+package io.jenkins.plugins.analysis.core.model;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+
+import edu.umd.cs.findbugs.annotations.NonNull;
+
+import hudson.Extension;
+import hudson.model.Action;
+import hudson.model.Job;
+import hudson.model.Run;
+import jenkins.model.TransientActionFactory;
+
+/**
+ * Registers this class as a Jenkins extension that provides fallback for analysis builds.
+ * This helps display warnings in the job view even when no analysis is present in the latest build.
+ * The actions are rendered by finding the most recent build with valid {@link ResultAction} instances,
+ * and then attaching the corresponding {@link JobAction} and {@link TransientProjectResultAction} to the job.
+ */
+@Extension
+public final class MissingResultFallbackHandler extends TransientActionFactory<Job<?, ?>> {
+    @Override
+    @SuppressWarnings("unchecked")
+    public Class<Job<?, ?>> type() {
+        return (Class) Job.class;
+    }
+
+    @NonNull
+    @Override
+    public Collection<? extends Action> createFor(@NonNull final Job<?, ?> target) {
+        Run<?, ?> currentBuild = target.getLastBuild();
+        if (currentBuild == null || currentBuild.isBuilding()) {
+            return Collections.emptyList();
+        }
+
+        List<ResultAction> currentResultActions = currentBuild.getActions(ResultAction.class);
+        if (!currentResultActions.isEmpty()) {
+            return Collections.emptyList();
+        }
+
+        for (Run<?, ?> previousBuild = currentBuild.getPreviousBuild(); previousBuild != null; previousBuild = previousBuild.getPreviousBuild()) {
+            List<ResultAction> resultActions = previousBuild.getActions(ResultAction.class);
+
+            List<Action> actions = new ArrayList<>();
+            for (ResultAction action : resultActions) {
+                actions.addAll(action.getProjectActions());
+                actions.add(new TransientProjectResultAction(action));
+            }
+
+            if (!resultActions.isEmpty()) {
+                return actions;
+            }
+        }
+
+        return Collections.emptyList();
+    }
+
+    /**
+     * A wrapper record for {@link ResultAction} that provides an absolute URL for the link on the side panel.
+     *
+     * @param resultAction
+     *          Valid Result Action
+     */
+    private record TransientProjectResultAction(ResultAction resultAction) implements Action {
+        @Override
+        public String getIconFileName() {
+            return resultAction.getIconFileName();
+        }
+
+        @Override
+        public String getDisplayName() {
+            return resultAction.getDisplayName();
+        }
+
+        @Override
+        public String getUrlName() {
+            return resultAction.getAbsoluteUrl();
+        }
+    }
+}

plugin/src/test/java/io/jenkins/plugins/analysis/warnings/steps/JobActionITest.java

@@ -12,6 +12,7 @@
 import hudson.model.Run;
 
 import io.jenkins.plugins.analysis.core.model.AggregatedTrendAction;
+import io.jenkins.plugins.analysis.core.model.MissingResultFallbackHandler;
 import io.jenkins.plugins.analysis.core.model.AnalysisResult;
 import io.jenkins.plugins.analysis.core.model.JobAction;
 import io.jenkins.plugins.analysis.core.model.ReportScanningTool;
@@ -228,6 +229,43 @@ void shouldHaveSidebarLinkEvenWhenLastActionHasNoResults() {
         assertThat(jobAction).isNotNull();
     }
 
+    /**
+     * Verifies the behaviour of {@link MissingResultFallbackHandler}.
+     */
+    @Test
+    void shouldAttachJobActionsWithoutRecordIssues() {
+        FreeStyleProject project = createFreeStyleProjectWithWorkspaceFilesWithSuffix(ECLIPSE_LOG);
+        enableEclipseWarnings(project);
+
+        Run<?, ?> firstBuild = buildWithResult(project, Result.SUCCESS);
+        List<ResultAction> firstBuildResultActions = firstBuild.getActions(ResultAction.class);
+        assertThat(firstBuildResultActions).isNotEmpty();
+
+        List<JobAction> jobActionsAfterFirstBuild = project.getActions(JobAction.class);
+        assertThat(jobActionsAfterFirstBuild).isNotEmpty();
+        assertThatTrendChartIsHidden(jobActionsAfterFirstBuild.get(0));
+
+        Run<?, ?> secondBuild = buildWithResult(project, Result.SUCCESS);
+        List<ResultAction> secondBuildResultActions = secondBuild.getActions(ResultAction.class);
+        assertThat(secondBuildResultActions).isNotEmpty();
+
+        List<JobAction> jobActionsAfterSecondBuild = project.getActions(JobAction.class);
+        assertThat(jobActionsAfterSecondBuild).isNotEmpty();
+        assertThatTrendChartIsVisible(jobActionsAfterSecondBuild.get(0));
+
+        project.getPublishersList().clear();
+
+        Run<?, ?> thirdBuild = buildWithResult(project, Result.SUCCESS);
+        List<ResultAction> thirdBuildResultActions = thirdBuild.getActions(ResultAction.class);
+        assertThat(thirdBuildResultActions).isEmpty();
+
+        List<JobAction> jobActionsAfterThirdBuild = project.getActions(JobAction.class);
+        assertThat(jobActionsAfterThirdBuild).isNotEmpty();
+        assertThat(jobActionsAfterSecondBuild.get(0).getId()).isEqualTo(jobActionsAfterThirdBuild.get(0).getId());
+        assertThat(jobActionsAfterSecondBuild.get(0).getUrlName()).isEqualTo(jobActionsAfterThirdBuild.get(0).getUrlName());
+        assertThatTrendChartIsVisible(jobActionsAfterThirdBuild.get(0));
+    }
+
     private void assertThatTrendChartIsVisible(final AsyncConfigurableTrendChart trendChart) {
         assertThat(trendChart.isTrendVisible()).isTrue();
     }