Merge pull request #1982 from jenkinsci/dependabot/maven/edu.hm.hafner-codingstyle-pom-5.16.0

Bump edu.hm.hafner:codingstyle-pom from 5.12.0 to 5.16.0

Author: uhafner

plugin/pom.xml

@@ -95,8 +95,6 @@
     <dependency>
       <groupId>io.jenkins.plugins</groupId>
       <artifactId>plugin-util-api</artifactId>
-      <!-- TODO: remove the version when a matching BOM is available -->
-      <version>6.0.0</version>
     </dependency>
     <dependency>
       <groupId>io.jenkins.plugins</groupId>
@@ -157,8 +155,6 @@
     <dependency>
       <groupId>io.jenkins.plugins</groupId>
       <artifactId>forensics-api</artifactId>
-      <!-- TODO: remove the version when a matching BOM is available -->
-      <version>3.0.0</version>
     </dependency>
     <dependency>
       <groupId>io.jenkins.plugins</groupId>
@@ -218,15 +214,11 @@
       <groupId>io.jenkins.plugins</groupId>
       <artifactId>forensics-api</artifactId>
       <classifier>tests</classifier>
-      <!-- TODO: remove the version when a matching BOM is available -->
-      <version>3.0.0</version>
       <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>io.jenkins.plugins</groupId>
       <artifactId>git-forensics</artifactId>
-      <!-- TODO: remove the version when a matching BOM is available -->
-      <version>3.1.0</version>
       <scope>test</scope>
     </dependency>
     <dependency>
@@ -307,8 +299,6 @@
     <dependency>
       <groupId>io.jenkins.plugins</groupId>
       <artifactId>plugin-util-api</artifactId>
-      <!-- TODO: remove the version when a matching BOM is available -->
-      <version>6.0.0</version>
       <classifier>tests</classifier>
       <scope>test</scope>
       <exclusions>
@@ -344,7 +334,7 @@
       <version>${testcontainers.version}</version>
       <scope>test</scope>
     </dependency>
-    <!-- Form element path plugin to simplify location of UI elements in HtmlUnit tests -->
+    <!-- Form element path plugin to simplify the location of UI elements in HtmlUnit tests -->
     <dependency>
       <groupId>org.jenkins-ci.plugins</groupId>
       <artifactId>form-element-path</artifactId>

ui-tests/etc/assertj-templates/soft_assertions_entry_point_class_template.txt

@@ -3,7 +3,6 @@ package ${package};
 /**
  * Entry point for soft assertions of different data types.
  */
-@edu.umd.cs.findbugs.annotations.SuppressFBWarnings("NM")
 @edu.hm.hafner.util.Generated(value="assertj-assertions-generator")
 public class SoftAssertions extends org.assertj.core.api.AutoCloseableSoftAssertions {
 ${all_assertions_entry_points}

ui-tests/pom.xml

@@ -5,7 +5,7 @@
   <parent>
     <groupId>edu.hm.hafner</groupId>
     <artifactId>codingstyle-pom</artifactId>
-    <version>5.12.0</version>
+    <version>5.16.0</version>
     <relativePath />
   </parent>
 

ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/AbstractIssuesTable.java

@@ -1,14 +1,12 @@
 package io.jenkins.plugins.analysis.warnings;
 
-import java.util.ArrayList;
-import java.util.List;
-import java.util.stream.Collectors;
-
 import org.apache.commons.lang3.StringUtils;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
 
 import io.jenkins.plugins.analysis.warnings.IssuesTable.Header;
 
@@ -21,7 +19,6 @@
  *
  * @author Stephan Plöderl
  */
-@SuppressFBWarnings("EI")
 abstract class AbstractIssuesTable<T extends GenericTableRow> {
     private final AnalysisResult analysisResult;
     private final List<T> tableRows = new ArrayList<>();

ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/AnalysisResult.java

@@ -7,8 +7,6 @@
 
 import com.google.inject.Injector;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
-
 import java.net.URL;
 import java.util.Collection;
 import java.util.List;
@@ -47,16 +45,16 @@ public AnalysisResult(final Build parent, final String id) {
 
     /**
      * Creates an instance of the page displaying the details of the issues. This constructor is used for injecting a
-     * filtered instance of the page (e.g. by clicking on links which open a filtered instance of a AnalysisResult.
+     * filtered instance of the page (e.g., by clicking on links which open a filtered instance of a AnalysisResult.
      *
      * @param injector
      *         the injector of the page
      * @param url
      *         the url of the page
      * @param id
-     *         the id of  the result page (e.g., simian or cpd)
+     *         the id of the result page (e.g., simian or cpd)
      */
-    @SuppressWarnings("unused") // Required to dynamically create page object using reflection
+    @SuppressWarnings("unused") // Required to dynamically create a page object using reflection
     public AnalysisResult(final Injector injector, final URL url, final String id) {
         super(injector, url);
 
@@ -71,7 +69,7 @@ public AnalysisResult(final Injector injector, final URL url, final String id) {
     public Tab getActiveTab() {
         WebElement activeTab = find(By.xpath("//a[@role='tab' and contains(@class, 'active')]"));
 
-        return Tab.valueWithHref(extractRelativeUrl(activeTab.getAttribute(TARGET_HREF)));
+        return Tab.valueWithHref(extractRelativeUrl(activeTab.getDomAttribute(TARGET_HREF)));
     }
 
     /**
@@ -81,7 +79,7 @@ public Tab getActiveTab() {
      */
     public Collection<Tab> getAvailableTabs() {
         return all(By.xpath("//a[@role='tab']")).stream()
-                .map(tab -> tab.getAttribute(TARGET_HREF))
+                .map(tab -> tab.getDomAttribute(TARGET_HREF))
                 .map(this::extractRelativeUrl)
                 .map(Tab::valueWithHref)
                 .collect(Collectors.toList());
@@ -93,7 +91,7 @@ private String extractRelativeUrl(final String absoluteUrl) {
 
     /**
      * Returns the total number of issues. This method requires that one of the tabs is shown that shows the total
-     * number of issues in the footer. I.e. the {@link Tab#ISSUES} and {@link Tab#BLAMES}.
+     * number of issues in the footer. I.e., the {@link Tab#ISSUES} and {@link Tab#BLAMES}.
      *
      * @return the total number of issues
      */
@@ -103,7 +101,7 @@ public int getTotal() {
 
     /**
      * Returns the total number of new issues. This method requires that one of the tabs is shown that shows the total
-     * number of issues in the footer. I.e. the {@link Tab#ISSUES} and {@link Tab#BLAMES}.
+     * number of issues in the footer. I.e., the {@link Tab#ISSUES} and {@link Tab#BLAMES}.
      *
      * @return the total number of new issues
      */
@@ -166,7 +164,7 @@ private WebElement selectTab(final Tab issues) {
 
     /**
      * Opens the analysis details page, selects the tab {@link Tab#CATEGORIES} and returns the {@link PageObject} of the
-     * categories table.
+     * category table.
      *
      * @param tab
      *         the tab to open
@@ -180,9 +178,9 @@ public PropertyDetailsTable openPropertiesTable(final Tab tab) {
 
     /**
      * Opens the analysis details page, selects the tab {@link Tab#BLAMES} and returns the {@link PageObject} of the
-     * blames table.
+     * blame table.
      *
-     * @return page object of the blames table.
+     * @return page object of the blame table.
      */
     public BlamesTable openBlamesTable() {
         openTab(Tab.BLAMES);
@@ -297,7 +295,6 @@ private WebElement getTrendChart() {
     /**
      * Clicks the next-button to cycle through the Trend Charts.
      */
-    @SuppressFBWarnings(value = "THROWS", justification = "3rd party library we cannot change")
     public void clickNextOnTrendCarousel() {
         WebElement trendChart = getTrendChart();
         WebElement activeChart = trendChart.findElement(By.className("active"));

ui-tests/src/test/java/io/jenkins/plugins/analysis/warnings/GitForensicsUiTest.java

@@ -1,9 +1,5 @@
 package io.jenkins.plugins.analysis.warnings;
 
-import java.io.IOException;
-import java.net.MalformedURLException;
-import java.util.HashMap;
-import java.util.Map;
 import javax.inject.Inject;
 
 import org.junit.After;
@@ -14,6 +10,11 @@
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
+import java.io.IOException;
+import java.net.MalformedURLException;
+import java.util.HashMap;
+import java.util.Map;
+
 import org.jenkinsci.test.acceptance.docker.DockerContainerHolder;
 import org.jenkinsci.test.acceptance.docker.fixtures.GitContainer;
 import org.jenkinsci.test.acceptance.junit.DockerTest;
@@ -125,7 +126,6 @@ public void initGitRepository() {
 
     /** Dispose the docker container. */
     @After
-    @SuppressFBWarnings("BC_UNCONFIRMED_CAST_OF_RETURN_VALUE")
     public void disposeContainer() {
         gitServer.get().close();
     }