-
Notifications
You must be signed in to change notification settings - Fork 8
fix: Cannot setup a pipeline #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
...ain/java/org/jenkinsci/plugins/tuleap_git_branch_source/TuleapSCMSourceFormValidator.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package org.jenkinsci.plugins.tuleap_git_branch_source; | ||
|
|
||
| import hudson.util.FormValidation; | ||
|
|
||
| public class TuleapSCMSourceFormValidator { | ||
|
|
||
| public static FormValidation doCheckProjectId( | ||
| String projectId) { | ||
| if (projectId.isEmpty()) { | ||
| return FormValidation.error(Messages.TuleapSCMSource_aGitRepositoryIsRequiredError()); | ||
| } | ||
| return FormValidation.ok(); | ||
| } | ||
|
|
||
| public static FormValidation doCheckRepositoryPath( | ||
| String repositoryPath) { | ||
| if (repositoryPath.isEmpty()) { | ||
| return FormValidation.error(Messages.TuleapSCMSource_aGitRepositoryIsRequiredError()); | ||
| } | ||
| return FormValidation.ok(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
...java/org/jenkinsci/plugins/tuleap_git_branch_source/TuleapSCMSourceFormValidatorTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| package org.jenkinsci.plugins.tuleap_git_branch_source; | ||
|
|
||
|
|
||
| import hudson.util.FormValidation; | ||
| import org.junit.Test; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| public class TuleapSCMSourceFormValidatorTest { | ||
|
|
||
| @Test | ||
| public void testTheFormValidationIsInErrorIfTheProjectIsEmpty() { | ||
| FormValidation result = TuleapSCMSourceFormValidator.doCheckProjectId(""); | ||
| assertEquals( | ||
| FormValidation.Kind.ERROR, | ||
| result.kind | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTheFormValidationIsOkIfTheProjectIsGiven() { | ||
| FormValidation result = TuleapSCMSourceFormValidator.doCheckProjectId("152"); | ||
| assertEquals( | ||
| FormValidation.Kind.OK, | ||
| result.kind | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTheFormValidationIsOkIfTheRepositoryPathIsEmpty() { | ||
| FormValidation result = TuleapSCMSourceFormValidator.doCheckRepositoryPath(""); | ||
| assertEquals( | ||
| FormValidation.Kind.ERROR, | ||
| result.kind | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTheFormValidationIsOkIfTheRepositoryPathIsGiven() { | ||
| FormValidation result = TuleapSCMSourceFormValidator.doCheckProjectId("project/repo.git"); | ||
| assertEquals( | ||
| FormValidation.Kind.OK, | ||
| result.kind | ||
| ); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is possible, I think it would be better if this constructor also populated
this.projectandthis.projectIditself so that we are always sure of what we have.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already thought to do that, but I think this is not a good idea because of the
DataBoundConstructor, it does some automagic binding, and it may introduce some unwanted side effect which can be hard to debugThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the
@DataBounConstructoronly taking into account the arguments of the constructior ieprojectIdandrepositoryPath?https://javadoc.jenkins.io/component/stapler/org/kohsuke/stapler/DataBoundConstructor.html
Or are your worried about something else that I don't see ? I haven't looked into this in quite a while...