Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tuleap job should send the right SHA-1 to the Tuleap git repository #353

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

robinsoc
Copy link
Contributor

request #21765 Tuleap PR autonotification notify the git repository with a inexistent SHA-1

For each checkouted git repository by Jenkins a new Git Build Data is
created. The current implementation does not take in account that
case, the consequence is when there are more than one Git Build Data,
we may notify the Tuleap git repository with an invalid SHA-1.

To test, you can use a shared library and add it in your Jenkinsfile
For example, you can use: https://github.com/monodot/pipeline-library-demo as shared library
=> The right Tuleap repository with the right SHA-1 should be notified

request #21765 Tuleap PR autonotification notify the git repository with a inexistent SHA-1

For each checkouted git repository by Jenkins a new Git Build Data is
created. The current implementation does not take in account that
case, the consequence is when there are more than one Git Build Data,
we may notify the Tuleap git repository with an invalid SHA-1.

To test, you can use a shared library and add it in your Jenkinsfile
For example, you can use: https://github.com/monodot/pipeline-library-demo as shared library
=> The right Tuleap repository with the right SHA-1 should be notified
@robinsoc robinsoc requested a review from Erwyn May 30, 2022 10:22
@Erwyn Erwyn merged commit 0605115 into master Jun 9, 2022
@Erwyn Erwyn deleted the fix/notification-fail branch June 9, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants