Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the Tuleap Pull Request configuration trait #252

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

robinsoc
Copy link
Contributor

@robinsoc robinsoc commented Jul 9, 2021

Part of story#18320 native support of pull requests in tuleap branch source jenkins plugin

This is the introduction of the support of pull request in the plugin.
This contribution add a new configuration trait which allows the user to
retrieve the pull request (or not).

Note: this contribution add the traits only!

How to test:

  • Create or Update a Tuleap job by adding or removing the the Tuleap Pull Requests autodiscovery configuration trait
  • Launch the scan.
    => If the traits was added, then you should see a sentence in the Tuleap
    Jenkins job log which says that the Pull request will be retrieved.
    => If the traits was not added or removed, then no sentence is displayed

Part of [story#18320](https://tuleap.net/plugins/tracker/?aid=18320) native support of pull requests in tuleap branch source jenkins plugin

This is the introduction of the support of pull request in the plugin.
This contribution add a new configuration trait which allows the user to
retrieve the pull request (or not).

Note: this contribution add the traits only!

How to test:
 - Create or Update a Tuleap job by adding or removing the the `Tuleap
   Pull Requests autodiscovery` configuration trait
 - Launch the scan.
=> If the traits was added, then you should see a sentence in the Tuleap
Jenkins job log which says that the Pull request will be retrieved.
=> If the traits was not added or removed, then no sentence is displayed
@robinsoc robinsoc requested a review from Erwyn July 19, 2021 08:38
Copy link
Collaborator

@Erwyn Erwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR trait should be added by default when creating a new Job

@robinsoc robinsoc requested a review from Erwyn July 19, 2021 15:39
@Erwyn Erwyn merged commit 6087c83 into master Jul 20, 2021
@Erwyn Erwyn deleted the feature/add-pr-trait branch July 20, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants