Skip to content

add defaults for slackNotifier job DSL api #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ulich opened this issue Jul 1, 2016 · 1 comment · Fixed by #236
Closed

add defaults for slackNotifier job DSL api #232

ulich opened this issue Jul 1, 2016 · 1 comment · Fixed by #236
Milestone

Comments

@ulich
Copy link

ulich commented Jul 1, 2016

We are using the job dsl to describe our jobs. The slackNotifications method is deprecated in favor of the new slackNotifier method that comes from the extension points.

The old slackNotifications provided many defaults so we could configure e.g. the slackDomain, token, etc. globally in jenkins and then only add a small block like

    publishers {
        slackNotifications {
            projectChannel('channel')
            notifyUnstable()
            notifyFailure()
            notifyBackToNormal()
        }
    }

but with the new slackNotifier method we have to specify all the properties:

ERROR: the following options are required and must be specified: teamDomain, authToken, buildServerUrl, sendAs, startNotification, notifyAborted, notifyNotBuilt, notifySuccess, notifyRepeatedFailure, includeTestSummary, commitInfoChoice, includeCustomMessage, customMessage

Is it possible to add defaults with extension points?

samrocketman added a commit that referenced this issue Feb 26, 2017
resolve #232 use DataBoundSetter for optional params
@samrocketman samrocketman added this to the slack-2.2 milestone Mar 6, 2017
@samrocketman
Copy link
Member

Feel free to subscribe to #296 for updates related to Slack Plugin 2.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants