Skip to content

Fix JenkinsWhitelistTest on 2.477 incremental #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Fix JenkinsWhitelistTest on 2.477 incremental #578

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f3bad4
Test with Jenkins 2.477-rc35350.7ff5a_a_a_0fdc3 incremental
MarkEWaite Sep 14, 2024
e81d38d
Exclude hudson.model.Run.getFullDisplayName from sanity test
MarkEWaite Sep 14, 2024
88f2cb9
Revert "Test with Jenkins 2.477-rc35350.7ff5a_a_a_0fdc3 incremental"
MarkEWaite Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...est/java/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/StaticWhitelistTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,11 @@
new MethodSignature(MatchResult.class, "hasMatch"),
new MethodSignature(MatchResult.class, "namedGroups"),
new MethodSignature(MatchResult.class, "start", String.class),
// TODO No longer exists after Jenkins includes https://github.com/jenkinsci/jenkins/pull/9674

Check warning on line 159 in src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/StaticWhitelistTest.java

View check run for this annotation

ci.jenkins.io / Open Tasks Scanner

TODO 

NORMAL:
No longer exists after Jenkins includes https://github.com/jenkinsci/jenkins/pull/9674
// Remove once plugin depends on Jenkins 2.477 or newer
// Remove from jenkins-whitelist at the same time
new MethodSignature("hudson.model.Run", "getFullDisplayName"),
// TODO Do not exist until Jenkins includes https://github.com/jenkinsci/jenkins/pull/9674

Check warning on line 163 in src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/StaticWhitelistTest.java

View check run for this annotation

ci.jenkins.io / Open Tasks Scanner

TODO 

NORMAL:
Do not exist until Jenkins includes https://github.com/jenkinsci/jenkins/pull/9674
new MethodSignature("jenkins.model.HistoricalBuild", "getFullDisplayName")
));

Expand Down