Skip to content

Update ScriptApprovalLink icon #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Update ScriptApprovalLink icon #521

merged 1 commit into from
Aug 23, 2023

Conversation

strangelookingnerd
Copy link
Contributor

Update the icon of the "In-process Script Approval" menu under "Manage Jenkins".
The idea is to harmonize the look and feel of the page since most other plugins and especially the core functions there also use these kind of icons.

I opted with built-in icons from Jenkins core to not introduce any new dependencies.

Testing done

Manual starting local instance, comparing results.

Before
before
After
after

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner August 23, 2023 13:52
@jglick jglick merged commit 66c1964 into jenkinsci:master Aug 23, 2023
@strangelookingnerd strangelookingnerd deleted the update_script_approval_icon branch August 23, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants