[JENKINS-65237] Bump Groovy from 2.4.12 to 2.4.21 #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
reviewed
Jan 6, 2022
Co-authored-by: Jesse Glick <[email protected]>
Co-authored-by: Jesse Glick <[email protected]>
jglick
approved these changes
Jan 7, 2022
|
Yeah, I'm not in any rush for this to be merged. I just wanted to file the PR to close the loop on remaining tasks regarding the Groovy upgrade. |
6 tasks
|
Heyo @basil, do you look forward to merge this PR anytime soon? See my PR linked, it would depend on the baseline bump you look forward to do. |
I am not a maintainer, but perhaps @car-roll could consider merging this now that we have an additional use case in mind. |
timja
reviewed
Feb 16, 2022
timja
approved these changes
Feb 18, 2022
jglick
approved these changes
Feb 18, 2022
Co-authored-by: Jesse Glick <[email protected]>
|
BTW my general preference is for all of my PRs to be squash-merged to keep the history clean, but I recognize that others have different preferences. I do not feel strongly about this, and ultimately the decision is up to the maintainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting to jenkinsci/jenkins#5939, specifically this comment:
The change to
GroovyCallSiteSelectorTestadapts a test that was using a Guava class that was removed in the latest version of Guava, which is now present in core. I resolved this issue by replacing the usage with the equivalent class from Apache Commons IO.