Skip to content

Prefer per plugin url over JENKINS_UC_DOWNLOAD_URL #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

timja
Copy link
Member

@timja timja commented Oct 10, 2024

See #416 (comment)

Testing done

Ensured that:

export JENKINS_UC_DOWNLOAD_URL=http://localhost:8080
java -jar plugin-management-cli/target/jenkins-plugin-manager-2.13.2-SNAPSHOT.jar --plugins mailer:1.34:https://get.jenkins.io/plugins/mailer/1.34/mailer.hpi -d /tmp/plugins --jenkins-version 2.440 --verbose

downloads from get.jenkins.io

and ensured:

export JENKINS_UC_DOWNLOAD_URL=http://localhost:8080
java -jar plugin-management-cli/target/jenkins-plugin-manager-2.13.2-SNAPSHOT.jar --plugins mailer:1.34 -d /tmp/plugins --jenkins-version 2.440 --verbose

downloads from localhost:8080

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja added the bug Something isn't working label Oct 10, 2024
@timja timja merged commit 9695387 into jenkinsci:master Oct 10, 2024
16 checks passed
@timja timja deleted the update-precedence branch October 10, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant