Skip to content

[JENKINS-63373] writeYaml should support writing a list as multiple d… #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2021
Merged

[JENKINS-63373] writeYaml should support writing a list as multiple d… #87

merged 1 commit into from
Mar 25, 2021

Conversation

ian-twilightcoder
Copy link
Contributor

…ocuments

Add a datas parameter to writeYaml as an alternate to data. datas must be a collection, and each element will be written as a YAML document in the file.

@ian-twilightcoder
Copy link
Contributor Author

(This time I have permission from my work to post this. Sorry about the mixup last time.)

rsandell
rsandell requested changes Oct 23, 2020
View reviewed changes
Copy link
Member

@rsandell rsandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great over all, just some minor comments.

@rsandell rsandell mentioned this pull request Oct 23, 2020
Merged
@ian-twilightcoder
Copy link
Contributor Author

I think I got all the comments addressed, is there anything else I need to do before this can be merged?

@rsandell
Copy link
Member

Sorry, I've been on vacation and trying to catch up after getting back.

@rittneje
Copy link
Contributor

@ian-twilightcoder Thanks for this change, would be useful for us as well. Can you make it work with the returnText flag I just added?

@ian-twilightcoder
Copy link
Contributor Author

@ian-twilightcoder Thanks for this change, would be useful for us as well. Can you make it work with the returnText flag I just added?

Thanks for catching that, fixed up ReturnTextExecution.run. I'm not sure I got the constructor right though, I've had a tough time finding Stapler documentation for people who don't know anything about Stapler (me).

@ian-twilightcoder
[JENKINS-63373] writeYaml should support writing a list as multiple d…
a39bbd9 
…ocuments

Add a `datas` parameter to writeYaml as an alternate to `data`. `datas` must be a collection, and each element will be written as a YAML document in the file.
@ian-twilightcoder
Copy link
Contributor Author

Sorry, I've been on vacation and trying to catch up after getting back.

@rsandell No problem. Got the merge conflicts fixed and I think this should be ready to go now.

@rsandell rsandell merged commit 78fe6ce into jenkinsci:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsandell rsandell rsandell approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-twilightcoder @rsandell @rittneje