[JENKINS-70557] Allow readYaml max aliases to be set via system property at startup #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the default for the readYaml step
rsandell
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Looks OK to me.
It would be nice if it was possible to have a test for it, it is slightly embarrasing that this bug slipped through :)
You could use org.jvnet.hudson.test.FlagRule in a test to set a system property and clean it up after the test. There are some tests in org.jenkinsci.plugins.pipeline.utility.steps.conf.ReadYamlStepTest that could give you inspiration around testing max aliases for collections in general.
rsandell
requested changes
Feb 21, 2023
...est/java/org/jenkinsci/plugins/pipeline/utility/steps/conf/ReadYamlStepSystemProperties.java
Outdated
Show resolved
Hide resolved
…f/ReadYamlStepSystemProperties.java Co-authored-by: Robert Sandell <[email protected]>
|
Thanks @rsandell , it's ready for re-review now. |
rsandell
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.jenkins.io/browse/JENKINS-70557
This code was previously modified to add system properties under:
That previous fix works when you set them using
Manage Jenkins->Script console, but not via startup arguments (as described in JENKINS-70557)This fix makes it possible to set these system properties at startup.
Tested with the testcase from JENKINS-70557, using: