Deprecated API usages replaced

[offa]

Replaces some calls to deprecated methods replaced.

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[basil]

If you like fixing things like this, there are a ton (dozens or hundreds) of tests in Jenkins core that could benefit from conversion of try/fail() to assertThrows. I've been fixing them as I come across them, but there are a lot more still left if you're interested in helping out.

[offa]

I improve such things when I'm already working on a project (preparing a PR for this one), but haven't worked at core yet. Maybe it's a good starting point though, we'll see …

Thanks for the suggestion.

[offa]

ping @rsandell