Skip to content

Allow to disable Stage View in the main job page through system property #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

felipecrs
Copy link
Contributor

I have some really big jobs and my Jenkins server is running slow. Upon investigation, I noticed that Jenkins spends a lot of time processing API requests from this plugin.

While the Stage View information is very useful, I do not need it to be opened automatically when I open a job. There is a Full Stage View button in the job page that I can click if I want to see it.

This PR allows to disable the automatic opening of the Stage View when a job is opened. This is done by adding a new system property org.jenkinsci.pipeline.stageview.disabledOnMainJobPage as true. If not set, it behaves as before.

Testing done

Works great in my local tests.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@felipecrs felipecrs requested a review from a team as a code owner April 29, 2025 20:41
@olamy
Copy link
Member

olamy commented Apr 29, 2025

Sounds reasonable change but can you add some documentation about this in the README in the dedicated section?
https://github.com/jenkinsci/pipeline-stage-view-plugin?tab=readme-ov-file#configurable-properties
Thanks

@felipecrs
Copy link
Contributor Author

Sounds reasonable change but can you add some documentation about this in the README in the dedicated section? jenkinsci/pipeline-stage-view-plugin#configurable-properties Thanks

Absolutely!

@felipecrs
Copy link
Contributor Author

@olamy done. I tried to keep the same text style of the existing ones.

@olamy olamy merged commit 174f223 into jenkinsci:master Apr 29, 2025
16 checks passed
@felipecrs felipecrs deleted the allow-disable-job-page branch April 29, 2025 23:47
@felipecrs
Copy link
Contributor Author

@olamy I am extremely grateful for your quick expedition of this PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants