Skip to content

Fix - Concurrent jobs launch: start several cron expressions at the same time #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yevhen-hryhorevskyi
Copy link

Hi there,

I liked the plugin and idea of setting up multiple cron expressions with different parameters. I looked through readme and found an image where two jobs (#18, #19) were launched at the same time. That was exactly what I needed.

But, unfortunately, I was not able to setup configuration to run different periodical cron expressions at the same time.
Digging into the code, I realized that this plugin worked differently:

  • It runs a check every minute to launch a cron task with specific parameters.
  • It makes a lookup only for the first cron expression that should start at that moment.

Based on the documentation and real implementation, I concluded that there was a bug in code, or it was the desired behavior and misleading documentation.

@danielfariati
Copy link

I'm having the exact same issue described / solved in this pull-request.
It would be awesome if someone can merge this.

@batmat batmat self-requested a review August 28, 2020 20:40
@carlosaya
Copy link

same problem here! can this pull request get some love? 🙏

@wy-z
Copy link

wy-z commented Sep 8, 2020

I'm having the same issue too, hope this PR can be merged.

@BenCamareno
Copy link

Same issue as described, please merge

@batmat
Copy link
Member

batmat commented Nov 10, 2020

Hi everyone,

I'm the current maintainer of this plugin. TBH with myself, I lack the time to maintain this plugin, so if somebody can take over the maintenance, I'll be happy to hand it over.

Process: https://www.jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/

Thanks!

@batmat batmat removed their request for review November 17, 2020 09:42
@@ -28,14 +29,20 @@

@Test
public void create() throws Exception {
ParameterizedCronTabList testObject = ParameterizedCronTabList.create("* * * * *%foo=bar");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This second test should be split into a new test

@res0nance res0nance added the bug label Dec 24, 2020
@res0nance
Copy link

@yevhen-hryhorevskyi are you still interested in this PR?

@yevhen-hryhorevskyi
Copy link
Author

@res0nance Considering the number of comments to merge this PR, yes I'm still interested in it. Let me take care of the comments & merge conflicts later today

@res0nance
Copy link

@res0nance Considering the number of comments to merge this PR, yes I'm still interested in it. Let me take care of the comments & merge conflicts later today

Do you have time to still work on this? Would you like me to continue with this?

@chunming08
Copy link

@res0nance Considering the number of comments to merge this PR, yes I'm still interested in it. Let me take care of the comments & merge conflicts later today

Do you have time to still work on this? Would you like me to continue with this?

@res0nance , can you please kindly share the schedule of the next release of this plugin? It's been 4 months since last and I am still waiting for the functionality that this PR provides - #47

@res0nance
Copy link

@res0nance Considering the number of comments to merge this PR, yes I'm still interested in it. Let me take care of the comments & merge conflicts later today

Do you have time to still work on this? Would you like me to continue with this?

@res0nance , can you please kindly share the schedule of the next release of this plugin? It's been 4 months since last and I am still waiting for the functionality that this PR provides - #47

Probably releasing this today because i just wrote PR #105 to supersede this. Once merged there shouldn't be anything else outstanding.

@res0nance res0nance closed this Apr 28, 2021
@yevhen-hryhorevskyi yevhen-hryhorevskyi deleted the fix/multiple-jobs-in-same-minute-start branch February 3, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants