Fix Cron periodic work to run at the beginning of each minute. #205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous implementation, initially invocation time is aligned to the of the first minute, but eventually 1-minute period can flow because of local clock inaccuracy. This commit fixes this by dynamic calculation of delay before execution.
Details:
PeriodicWork uses java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate, which uses java.lang.System.nanoTime() to determine time elapsed. It does not strictly correlate with wall-clock time. In case we faced with, Cron periodic work became running at 59 second of each minute (our machine's clock is late) and sometimes some jobs became skip triggering
Testing done