[FIXED JENKINS-28121] Need to mkdirs before clone #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failure was being masked both in automated and manual tests by the CACHE_LOCAL_REPOS optimization. Just deleting that special case now; probably rarely useful in the field, and tends to hide behavioral differences.
| @@ -13,8 +13,7 @@ | |||
| <url>http://wiki.jenkins-ci.org/display/JENKINS/Mercurial+Plugin</url> | |||
|
|
|||
| <properties> | |||
| <jenkins.version>1.580.1</jenkins.version> | |||
| <java.level>6</java.level> | |||
| <jenkins.version>1.642.3</jenkins.version> | |||
There was a problem hiding this comment.
Need a new baseline to be able to run tests against reasonably modern versions of Pipeline; the 1.4.x line compatible with 1.580.x did not even include workflow-multibranch, which most naturally reproduces this error.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| @@ -809,6 +809,7 @@ private void clone(Run<?, ?> build, Launcher launcher, FilePath repository, Node | |||
| args.add(getSource(env)); | |||
| } | |||
| args.add(repository.getRemote()); | |||
| repository.mkdirs(); | |||
…r new builds upon commit.
| @@ -932,12 +933,8 @@ private boolean causedByMissingHg(IOException e) { | |||
| return message != null && message.startsWith("Cannot run program") && message.endsWith("No such file or directory"); | |||
| } | |||
|
|
|||
| static boolean CACHE_LOCAL_REPOS = false; | |||
There was a problem hiding this comment.
So what was the point of this such that we're getting rid of it now?
There was a problem hiding this comment.
It was a little faster. But for a situation unlikely to arise in production.
|
🐝 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-28121
Picks up tests from jenkinsci/workflow-scm-step-plugin#4 and jenkinsci/workflow-multibranch-plugin#17, and makes them pass when
CACHE_LOCAL_REPOSis deleted.@reviewbybees