Skip to content

Use standard SpotBugs exclusion file name #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

basil
Copy link
Member

@basil basil commented Nov 4, 2022

https://github.com/jenkinsci/plugin-pom/blob/61707aa156d83a3f5a962faf4113375f1266ce73/pom.xml#L1143 defines a standard location for the SpotBugs exclusion file throughout all plugins (src/spotbugs/spotbugs-excludes.xml) so there is no need to use a custom name in this plugin. This PR renames the file to the standard name used in other Jenkins plugins and removes the unnecessary customization of the spotbugs.excludeFilterFile property.

@basil basil requested a review from a team as a code owner November 4, 2022 16:49
@MarkEWaite MarkEWaite enabled auto-merge November 4, 2022 16:51
@MarkEWaite MarkEWaite merged commit 89a5b2e into jenkinsci:master Nov 4, 2022
@MarkEWaite MarkEWaite added the chore Maintenance label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants