Fix migrating settings from plugin 0.20 to 0.21+ #46
Conversation
|
@cloudbeesci code review, please 😄. |
|
cc @jhoblitt code review, please. |
| @Override | ||
| public void onLoaded() { | ||
| try { | ||
| Jenkins instance = Jenkins.getInstance(); |
There was a problem hiding this comment.
Need to fix indenting.
samrocketman
force-pushed
the
fix_migration_from_0.20
branch
from
645d36d to
fd3bb38
Compare
|
Fixed indenting and amended commit. |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
| import java.util.Set; | ||
| import java.util.logging.Logger; | ||
|
|
||
| import static java.util.logging.Level.*; |
There was a problem hiding this comment.
Looks like this was the only file importing java.util.logging.Level.*
fixes [JENKINS-29473]
samrocketman
force-pushed
the
fix_migration_from_0.20
branch
from
fd3bb38 to
76c9769
Compare
|
@jhoblitt I went ahead and removed checking for an empty string. Once that verifies I'm going to do another plugin release as 0.21.2. This problem will quickly exacerbate as more users attempt to upgrade so I want the patch to go out quick. There's been one duplicate issue created about it in JIRA. Thanks for your review 😄. If there's other code style changes or improvements we could always open a new pull request improving the style or length of lines. I'm open to aesthetic and cleanup changes. |
|
I have released plugin 0.21.2 to address this migration issue as quickly as possible. |
fixes JENKINS-29473. Authorization breaks when migrating from plugin 0.20 or below to 0.21 and above. This is due to OAuth scopes not existing in prior configurations. This patch fixes that.