Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Fleet Label Cloud and created tests for CasC #418

Merged
merged 21 commits into from
Nov 3, 2023
Merged

Conversation

GavinBurris42
Copy link
Collaborator

Updated FleetLabelCloud and created tests for Configuration as Code. Changed variables in FleetLabelCloud constructor from uninstantiated Integers to ints.

Testing done

Created a new test class to test Configuration as Code for FleetLabelCloud to test FleetLabelClouds created from CasC yaml files.

@GavinBurris42 GavinBurris42 requested a review from pdk27 October 31, 2023 19:34
@GavinBurris42 GavinBurris42 self-assigned this Oct 31, 2023
Copy link
Collaborator

@pdk27 pdk27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

@pdk27 pdk27 marked this pull request as ready for review November 3, 2023 06:56
@pdk27
Copy link
Collaborator

pdk27 commented Nov 3, 2023

@GavinBurris42 Can you update the destination branch for this PR to master?

@pdk27 pdk27 added the tests label Nov 3, 2023
@GavinBurris42 GavinBurris42 changed the base branch from CreateFleet to master November 3, 2023 14:57
@pdk27 pdk27 merged commit d5e8e94 into master Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants