Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling issue 329 #386

Merged
merged 2 commits into from
Jul 13, 2023
Merged

handling issue 329 #386

merged 2 commits into from
Jul 13, 2023

Conversation

naraharip2017
Copy link
Collaborator

Handling following issue

Testing done

  • Verified via UI, slave terminology is updated

Tasks

Preview Give feedback
No tasks being tracked yet.

@naraharip2017 naraharip2017 requested a review from pdk27 July 12, 2023 08:37
@naraharip2017 naraharip2017 self-assigned this Jul 12, 2023
@pdk27
Copy link
Collaborator

pdk27 commented Jul 12, 2023

Let's take this one step further and replace all occurrences of slave in the code too - https://github.com/search?q=repo%3Ajenkinsci%2Fec2-fleet-plugin+slave&type=code&p=1.

@naraharip2017
Copy link
Collaborator Author

Let's take this one step further and replace all occurrences of slave in the code too - https://github.com/search?q=repo%3Ajenkinsci%2Fec2-fleet-plugin+slave&type=code&p=1.

Updated in revision. Removed all references that are not either a link to a webpage using slave terminology or referencing slave objects from the jenkins libraries

Copy link
Collaborator

@pdk27 pdk27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 ⭐

@pdk27 pdk27 merged commit b5b4021 into master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants