Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring for clarity #381

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Refactoring for clarity #381

merged 2 commits into from
Jul 5, 2023

Conversation

pdk27
Copy link
Collaborator

@pdk27 pdk27 commented Jul 5, 2023 •
edited
Loading

Description

Refactoring for clarity, readability:

  • Added class comments for Jenkins extensions / subtype implementations
  • Consolidating AWS related classes into their own package
  • Reduced job sleep time from 30s to 5s to make integration tests run faster

@pdk27 pdk27 changed the title Refactor 2 Refactoring for clarity Jul 5, 2023
@pdk27 pdk27 marked this pull request as ready for review July 5, 2023 15:37
@pdk27 pdk27 requested a review from cjerad July 5, 2023 15:37
@pdk27 pdk27 requested review from naraharip2017 and LikithaVemulapalli and removed request for cjerad July 5, 2023 16:29
LikithaVemulapalli
LikithaVemulapalli approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@LikithaVemulapalli LikithaVemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

naraharip2017
naraharip2017 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@naraharip2017 naraharip2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pdk27 pdk27 merged commit 035a0c2 into jenkinsci:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naraharip2017 naraharip2017 naraharip2017 approved these changes

@LikithaVemulapalli LikithaVemulapalli LikithaVemulapalli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdk27 @naraharip2017 @LikithaVemulapalli